Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug in DataInfoBase table #115

Open
mohammadbashiri opened this issue Feb 19, 2021 · 1 comment
Open

Fix the bug in DataInfoBase table #115

mohammadbashiri opened this issue Feb 19, 2021 · 1 comment

Comments

@mohammadbashiri
Copy link
Collaborator

mohammadbashiri commented Feb 19, 2021

The following lines throws an error:

dataset_fn, dataset_config = (self.dataset_table & key).fn_config
data_info = dataset_fn(**dataset_config, return_data_info=True)

Because fn_config returns a string as dataset_fn:

nnfabrik/nnfabrik/main.py

Lines 233 to 236 in 744ae10

def fn_config(self):
dataset_fn, dataset_config = self.fetch1("dataset_fn", "dataset_config")
dataset_config = cleanup_numpy_scalar(dataset_config)
return dataset_fn, dataset_config

@chbehrens
Copy link
Contributor

Would it be possible to fix this some time soon? Adding just one line like
dataset_fn = self.dataset_table.resolve_fn(dataset_fn)
below l. 239 in trained_model.py should be enough as far as I can see. I can also make a pull request out of it if you prefer it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants