Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datajoint demo notebook differes in MEIMethod parameters from the datajoint free demo #38

Open
MaxFBurg opened this issue Apr 11, 2024 · 2 comments

Comments

@MaxFBurg
Copy link
Member

MaxFBurg commented Apr 11, 2024

Datajoint demo notebook

method_fn = "mei.methods.gradient_ascent"
method_config = dict(
    initial=dict(path="mei.initial.RandomNormal"),
    optimizer=dict(path="torch.optim.SGD", kwargs=dict(lr=0.1)),
    stopper=dict(path="mei.stoppers.NumIterations", kwargs=dict(num_iterations=1000)),
    objectives=[dict(path="mei.objectives.EvaluationObjective", kwargs=dict(interval=10))],
    device="cuda",
)
MEIMethod().add_method(method_fn, method_config, comment="My MEI method", skip_duplicates=True)
MEIMethod()

Uses lr=0.1, there resulting image looks like noise, which could confuse new users. The datajoint free pipe uses lr=1 which works better.

@PPierzc
Copy link
Member

PPierzc commented Apr 11, 2024

Want to push the update?

MaxFBurg added a commit to MaxFBurg/mei that referenced this issue Apr 11, 2024
@MaxFBurg
Copy link
Member Author

Sure: #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants