Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oauth2 and accesstoken #96

Open
CrackerakiUA opened this issue Apr 27, 2016 · 6 comments
Open

Oauth2 and accesstoken #96

CrackerakiUA opened this issue Apr 27, 2016 · 6 comments

Comments

@CrackerakiUA
Copy link

I am using this strategy from passport LINK
From that strategy i am getting access_token from dropbox, but when i put that access_token inside var client = app.client(access_token) it throws me an message { error_description: 'No auth function available for given request', error: 'invalid_request' } and status 400.

@g00dv1n
Copy link

g00dv1n commented May 6, 2016

@CrackerakiUA
Copy link
Author

this modules looks pretty outdated

@sintaxi
Copy link
Owner

sintaxi commented May 6, 2016

I don’t see what disparaging this library accomplishes.

This is a JavaScript library that wraps HTTP calls to a REST API. There is nothing special going on here. Before you throw the baby out with the bath water consider the following.

  • dbox has been used to sync terabytes of data in production environment.
  • dbox has 25 releases - all with release notes and tests.
  • dbox makes the OAuth handshake suck way less.

If you have found a bug and it would help your life if it were fixed the best thing you can do for yourself is fix it. I have found the best way to do this is by writing a failing test that expects the correct behavior, then changing the implementation to make the test pass. This will also help maintainers evaluate the PR mainly because it will demonstrate that the other tests do not fail.

If you are unwilling to fix but still want to be a good open source citizen then it is appreciated if you open an issue explaining the expected behavior and your findings. Include any other useful information when you do this such as version of node (super important these days) and operating system (things with file paths can differ greatly from system to system).

If you can’t fix it but want it fixed, then you are in the absolute best condition to learn something new. Ask a friend you know for help.

If Dropbox has totally deprecated this API then we probably need someone to look into the details and see if this library is work keeping active our not. Probably something anyone can do. I stopped paying attention to what Dropbox is up to so I am out of the loop.

Although I still use it, this library has for the most part outlived its usefulness to me so its really up to the community to pick up the torch if its wanted.

cheers,
Brock

@CrackerakiUA
Copy link
Author

@sintaxi for old projects where this were using it's will be good to play with it. But for new projects there are v2 of dropbox api and passport authentication which is easier. Bad thing here is that in readme we don't say something that we use v1, i spend some time to found it.

@jstroem
Copy link
Contributor

jstroem commented May 9, 2016

@CrackerakiUA Then help the hole community and make a pull request with a change to the readme stating that this only works for v1 (and a link to another repo if a person would wanna use v2, if you found another repo).

@CrackerakiUA
Copy link
Author

@sintaxi i have started other plugin with v2, but it's still under developing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants