Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential backoff factor was not being enough #91

Open
rafaelsantanaep opened this issue Oct 6, 2022 · 0 comments
Open

Exponential backoff factor was not being enough #91

rafaelsantanaep opened this issue Oct 6, 2022 · 0 comments

Comments

@rafaelsantanaep
Copy link

rafaelsantanaep commented Oct 6, 2022

The current exponential backoff factor is 3.

Context

  • I have an airflow pipeline that extracts data from 12 spreadsheets with 20k rows each.
  • The steps ran sequentially.
  • In one of the steps, intermittently, the pipeline failed multiple times because the number of retries of the exponential backoff is exceeded. As you can see in the image below:
    image

Proposal

By changing the exponential factor from 3 to 4 in a fork of this repository, I was able to fix this issue on my pipeline.

    @backoff.on_exception(backoff.expo,
                          (Server5xxError, ConnectionError, Server429Error),
                          max_tries=7,
                          factor=3,
                          jitter=None)
    @utils.ratelimit(100, 100)

Can we implement this change or are there any problems that I'm not aware of?

I really would like to use the official version of this tap.

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant