Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't close devTools using the shortcut while it is focused #76

Open
astoilkov opened this issue Jun 28, 2019 · 0 comments
Open

Can't close devTools using the shortcut while it is focused #76

astoilkov opened this issue Jun 28, 2019 · 0 comments

Comments

@astoilkov
Copy link

Steps to reproduce:

  • The default Electron menu should be replaced with a custom menu so the Toggle Dev Tools menu item doesn't exist
  • Open devTools
  • While devTools is focused click the shortcut for closing devTools

This can be replicated in Caprine where electron-debug is used.

I see two possible solutions for this problem:

  1. electron-localshortcut to not disable the shortcuts when devTools is focused
  2. add an option in electron-debug which adds a menu item - the menu item works when devTools is focused so this will fix the problem

I am not entirely sure why the shortcut for reloading the page works while devTools is focused. Maybe this could be the key to solving this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@astoilkov