Composite with Union gives unexpected results

[numToStr]

Hi,

I was making a schema where i used Type.Union inside Type.Composite and i noticed that the validation doesn't seems to work as expected.

Taking the following example: I want statuscode to be required when the statecode is either 1 or 2, otherwise i don't care about statuscode

const firstSchema = Type.Union([
  Type.Object(
    {
      statecode: Type.Literal(0)
    },
    { additionalProperties: false }
  ),
  Type.Object(
    {
      statecode: Type.Union([Type.Literal(1), Type.Literal(2)]),
      statuscode: Type.Number()
    },
    { additionalProperties: false }
  )
]);

When i validate the value using the above schema on its own it works as expected.

console.log({
  a: Value.Decode(firstSchema, [], { statecode: 1, statuscode: 12234234 }),
  b: Value.Decode(firstSchema, [], { statecode: 0 })
});

// { a: { statecode: 1, statuscode: 12234234 }, b: { statecode: 0 } }

But as soon i include the above union schema in a Type.Composite it starts to give false positive.

const secondSchema = Type.Composite([
  firstSchema,
  Type.Object({
    accountid: Type.String({
      format: 'uuid',
    }),
  })
]);

console.log({
  a: Value.Decode(secondSchema, [], { statecode: 1, accountid: '7731c8b9-15a0-452d-b237-e9f5210d40d4' }),
});

// { a: { statecode: 1, accountid: '7731c8b9-15a0-452d-b237-e9f5210d40d4' } }

This validation should give error because statecode is 1 which make statuscode a required field. I am not sure what i am doing wrong so any help would be appreciated.

[numToStr]

Got the answer for now #894