Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rack::Logger is deprecated and will be removed in Rack 3.2 #2018

Closed
Tracked by #2016
, #2035
...
dentarg opened this issue Jun 18, 2024 · 1 comment · Fixed by #2035
Closed
Tracked by #2016
, #2035
...

Rack::Logger is deprecated and will be removed in Rack 3.2 #2018

dentarg opened this issue Jun 18, 2024 · 1 comment · Fixed by #2035
Assignees
@dentarg
Labels
bug ci / testing

Comments

@dentarg
Copy link
Member

dentarg commented Jun 18, 2024

The warning causes the tests to fail, I guess it is a good thing, so we noticed in advance.

From https://github.com/sinatra/sinatra/actions/runs/9565078027/job/26367226933#step:5:25

  1) Failure:
IntegrationTest#test_with_puma_does_not_generate_warnings_0 [test/integration_test.rb:58]:
--- expected
+++ actual
@@ -1 +1 @@
-[]
+["lib/sinatra/base.rb:1849: warning: Rack::Logger is deprecated and will be removed in Rack 3.2."]


  2) Failure:
IntegrationTest#test_with_falcon_does_not_generate_warnings_0 [test/integration_test.rb:58]:
--- expected
+++ actual
@@ -1 +1 @@
-[]
+["lib/sinatra/base.rb:1849: warning: Rack::Logger is deprecated and will be removed in Rack 3.2."]


  3) Failure:
IntegrationTest#test_with_webrick_does_not_generate_warnings_0 [test/integration_test.rb:58]:
--- expected
+++ actual
@@ -1 +1 @@
-[]
+["lib/sinatra/base.rb:1849: warning: Rack::Logger is deprecated and will be removed in Rack 3.2."]
@dentarg
Copy link
Member Author

dentarg commented Jun 19, 2024 •
edited
Loading

Relevant PR: rack/rack#2196

Also

@dentarg dentarg mentioned this issue Jun 19, 2024
Merged
@dentarg dentarg mentioned this issue Jul 10, 2024
Closed
3 tasks
@dentarg dentarg self-assigned this Jul 10, 2024
dentarg added a commit to dentarg/sinatra that referenced this issue Jul 10, 2024
@dentarg
Vendor Rack::Logger as Sinatra::Logger
888563c 
Add logger as dependency, to support future Ruby versions:
ruby/ruby@d7e558e

Close sinatra#2018
@ioquatix ioquatix mentioned this issue Jul 11, 2024
Closed
dentarg added a commit to dentarg/sinatra that referenced this issue Jul 11, 2024
@dentarg @ioquatix
Don't depend on Rack::Logger
6c487f0 
Rack::Logger was removed in Rack 3.2.

Close sinatra#2018

Co-authored-by: Samuel Williams <[email protected]>
@dentarg dentarg mentioned this issue Jul 11, 2024
Merged
3 tasks
dentarg added a commit that referenced this issue Jul 11, 2024
@dentarg @ioquatix
Don't depend on Rack::Logger
cbd733c 
Rack::Logger was removed in Rack 3.2.

Close #2018

Co-authored-by: Samuel Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dentarg dentarg

Labels
bug ci / testing
Projects
None yet
Milestone
No milestone
1 participant
@dentarg