Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping support for OAuth2 Implicit flow #244

Open
cicnavi opened this issue Aug 26, 2024 · 4 comments
Open

Consider dropping support for OAuth2 Implicit flow #244

cicnavi opened this issue Aug 26, 2024 · 4 comments
Assignees

Comments

@cicnavi
Copy link
Collaborator

cicnavi commented Aug 26, 2024

In the codebase we have OAuth2 Implicit Grant (src/Server/Grants/OAuth2ImplicitGrant.php), which is triggered by 'response_type' = 'token' param request on authorization endpoint.

This is not OIDC standard flow and there is low probability that anyone ever used it. It also brings some code branching which could be avoided if this flow can be dropped.

@cicnavi
Copy link
Collaborator Author

cicnavi commented Aug 26, 2024

@pradtke Can you please check your access logs if anyone actually used this? I couldn't find any...

@simplesamlphp simplesamlphp deleted a comment Aug 26, 2024
@pradtke
Copy link
Collaborator

pradtke commented Aug 26, 2024

I don't quite understand. Are you asking if we have any implicit flow usage, or if we have implicit flow usage that only requests token in the response_type (rather than requesting both id_token and token)? We have a very tiny amount of implicit usage that requests response_type=id_token%20token (I believe that is the required ones per the implicit spec).
Most browser apps use PKCE.

@cicnavi
Copy link
Collaborator Author

cicnavi commented Aug 27, 2024

I was only interested in response_type=token (OAuth2 implicit flow). I'm not interested in OIDC implicit flow, I won't touch that. So, there is no such cases, which is quite reasonable. I will probably go ahead and drop support for that when I get the chance...

@pradtke
Copy link
Collaborator

pradtke commented Aug 27, 2024

Ah, right I understand now. My brain autocorrected OAuth2 to OIDC :)
We have no such usage, and dropping it sounds good.

@cicnavi cicnavi self-assigned this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants