Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in request/defaults.js #4

Open
gentlefox opened this issue Feb 28, 2020 · 1 comment
Open

Typo in request/defaults.js #4

gentlefox opened this issue Feb 28, 2020 · 1 comment

Comments

@gentlefox
Copy link

Line 27:

  'servernam',

Should be:

   'servername',

Side note: love that you've created a HTTP Client solution using FP!
Maintaining 20+ servers / microservices that have all been using the old request library, and structurally outdated API format for constructing a request, error handling, and retries - a "One Size Fits Most" legacy. Replacing all this with your module, composing a default to match the old system, while optionally being able to override any other facet. Thank you for making it a coding pleasure.

@simov
Copy link
Owner

simov commented Feb 28, 2020

Good catch! Also thanks for the kind words, I'm glad you like it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants