From 3344d515277411123b490a4942bf41e93b737901 Mon Sep 17 00:00:00 2001
From: Simon Reinisch <simon@reinisch.io>
Date: Sun, 3 Sep 2023 14:14:43 +0200
Subject: [PATCH] refactor(core): refactor component types

---
 .../components/base/context-menu/ContextMenu.types.ts  | 10 ++++++++++
 src/app/components/base/context-menu/ContextMenu.vue   |  8 ++++++--
 src/app/components/base/context-menu/index.ts          |  9 ---------
 src/app/components/base/currency-cell/CurrencyCell.vue |  2 +-
 .../base/draggable/{types.ts => Draggable.types.ts}    |  0
 src/app/components/base/draggable/Draggable.vue        |  2 +-
 src/app/components/base/text-cell/TextCell.vue         |  6 +-----
 .../pages/navigation/currency/ChangeCurrencyButton.vue |  2 +-
 .../pages/navigation/language/ChangeLanguageButton.vue |  2 +-
 src/app/pages/navigation/year/SelectYearButton.vue     |  2 +-
 src/app/pages/shared/pane/BudgetGroup.vue              |  2 +-
 src/app/pages/shared/pane/BudgetGroups.vue             |  2 +-
 12 files changed, 24 insertions(+), 23 deletions(-)
 delete mode 100644 src/app/components/base/context-menu/index.ts
 rename src/app/components/base/draggable/{types.ts => Draggable.types.ts} (100%)

diff --git a/src/app/components/base/context-menu/ContextMenu.types.ts b/src/app/components/base/context-menu/ContextMenu.types.ts
index fe4be99a..079bf0b9 100644
--- a/src/app/components/base/context-menu/ContextMenu.types.ts
+++ b/src/app/components/base/context-menu/ContextMenu.types.ts
@@ -1,5 +1,15 @@
+import { AppIcon } from '@components/base/icon/Icon.types';
+
 export const ContextMenuStoreKey = Symbol('ContextMenuStore');
 
 export interface ContextMenuStore {
   close(): void;
 }
+
+export type ContextMenuOptionId = number | string;
+
+export interface ContextMenuOption {
+  id: ContextMenuOptionId;
+  icon?: AppIcon;
+  label?: string;
+}
diff --git a/src/app/components/base/context-menu/ContextMenu.vue b/src/app/components/base/context-menu/ContextMenu.vue
index d269a96b..9dd8daac 100644
--- a/src/app/components/base/context-menu/ContextMenu.vue
+++ b/src/app/components/base/context-menu/ContextMenu.vue
@@ -30,11 +30,15 @@
 <script lang="ts" setup>
 import { createPopper, Modifier, Instance, Placement } from '@popperjs/core';
 import { computed, provide, ref, useCssModule, watch } from 'vue';
-import { ContextMenuStore, ContextMenuStoreKey } from '@components/base/context-menu/ContextMenu.types';
+import {
+  ContextMenuOption,
+  ContextMenuOptionId,
+  ContextMenuStore,
+  ContextMenuStoreKey
+} from '@components/base/context-menu/ContextMenu.types';
 import { useOutOfElementClick } from '@composables';
 import { ClassNames } from '@utils';
 import ContextMenuButton from './ContextMenuButton.vue';
-import { ContextMenuOption, ContextMenuOptionId } from '.';
 
 const emit = defineEmits<{
   (e: 'select', option: ContextMenuOption): void;
diff --git a/src/app/components/base/context-menu/index.ts b/src/app/components/base/context-menu/index.ts
deleted file mode 100644
index a0051719..00000000
--- a/src/app/components/base/context-menu/index.ts
+++ /dev/null
@@ -1,9 +0,0 @@
-import { AppIcon } from '@components/base/icon/Icon.types';
-
-export type ContextMenuOptionId = number | string;
-
-export interface ContextMenuOption {
-  id: ContextMenuOptionId;
-  icon?: AppIcon;
-  label?: string;
-}
diff --git a/src/app/components/base/currency-cell/CurrencyCell.vue b/src/app/components/base/currency-cell/CurrencyCell.vue
index dc4cb141..9e8ebe6d 100644
--- a/src/app/components/base/currency-cell/CurrencyCell.vue
+++ b/src/app/components/base/currency-cell/CurrencyCell.vue
@@ -8,7 +8,7 @@
     @focus="focus"
     @input="change"
     @keydown="keydown"
-    @keydown.enter="input?.blur"
+    @keydown.enter="input?.blur()"
   />
 </template>
 
diff --git a/src/app/components/base/draggable/types.ts b/src/app/components/base/draggable/Draggable.types.ts
similarity index 100%
rename from src/app/components/base/draggable/types.ts
rename to src/app/components/base/draggable/Draggable.types.ts
diff --git a/src/app/components/base/draggable/Draggable.vue b/src/app/components/base/draggable/Draggable.vue
index a63c4e83..09718e44 100644
--- a/src/app/components/base/draggable/Draggable.vue
+++ b/src/app/components/base/draggable/Draggable.vue
@@ -28,8 +28,8 @@
 import { computed, ref } from 'vue';
 import Button from '@components/base/button/Button.vue';
 import { AppIcon } from '@components/base/icon/Icon.types';
+import { DraggableEvent, ReorderEvent } from './Draggable.types';
 import { store } from './store';
-import { DraggableEvent, ReorderEvent } from './types';
 
 const emit = defineEmits<{
   (e: 'drop', data: ReorderEvent): void;
diff --git a/src/app/components/base/text-cell/TextCell.vue b/src/app/components/base/text-cell/TextCell.vue
index 22f35130..8ba5f6ba 100644
--- a/src/app/components/base/text-cell/TextCell.vue
+++ b/src/app/components/base/text-cell/TextCell.vue
@@ -41,11 +41,7 @@ const classes = computed(() => [
 
 const focus = () => {
   focused.value = true;
-
-  nextTick(() => {
-    const element = input.value as HTMLInputElement;
-    element.select();
-  });
+  nextTick(() => (input.value as HTMLInputElement).select());
 };
 
 const change = (e: Event) => {
diff --git a/src/app/pages/navigation/currency/ChangeCurrencyButton.vue b/src/app/pages/navigation/currency/ChangeCurrencyButton.vue
index 1867774d..3f9b89b9 100644
--- a/src/app/pages/navigation/currency/ChangeCurrencyButton.vue
+++ b/src/app/pages/navigation/currency/ChangeCurrencyButton.vue
@@ -14,7 +14,7 @@
 import { computed } from 'vue';
 import { useI18n } from 'vue-i18n';
 import Button from '@components/base/button/Button.vue';
-import { ContextMenuOption } from '@components/base/context-menu';
+import { ContextMenuOption } from '@components/base/context-menu/ContextMenu.types';
 import ContextMenu from '@components/base/context-menu/ContextMenu.vue';
 import { useDataStore } from '@store/state';
 import { availableCurrencies, AvailableCurrency } from '@store/state/types';
diff --git a/src/app/pages/navigation/language/ChangeLanguageButton.vue b/src/app/pages/navigation/language/ChangeLanguageButton.vue
index d8c61d54..eb0c6d76 100644
--- a/src/app/pages/navigation/language/ChangeLanguageButton.vue
+++ b/src/app/pages/navigation/language/ChangeLanguageButton.vue
@@ -14,7 +14,7 @@
 import { computed } from 'vue';
 import { useI18n } from 'vue-i18n';
 import Button from '@components/base/button/Button.vue';
-import { ContextMenuOption } from '@components/base/context-menu';
+import { ContextMenuOption } from '@components/base/context-menu/ContextMenu.types';
 import ContextMenu from '@components/base/context-menu/ContextMenu.vue';
 import { AvailableLocale, availableLocales } from '@i18n/index';
 import { useDataStore } from '@store/state';
diff --git a/src/app/pages/navigation/year/SelectYearButton.vue b/src/app/pages/navigation/year/SelectYearButton.vue
index 53b30ee6..bbd25ab0 100644
--- a/src/app/pages/navigation/year/SelectYearButton.vue
+++ b/src/app/pages/navigation/year/SelectYearButton.vue
@@ -15,7 +15,7 @@
 import { computed } from 'vue';
 import { useI18n } from 'vue-i18n';
 import Button from '@components/base/button/Button.vue';
-import { ContextMenuOption } from '@components/base/context-menu';
+import { ContextMenuOption } from '@components/base/context-menu/ContextMenu.types';
 import ContextMenu from '@components/base/context-menu/ContextMenu.vue';
 import { useMediaQuery, useTime } from '@composables';
 import { useDataStore } from '@store/state';
diff --git a/src/app/pages/shared/pane/BudgetGroup.vue b/src/app/pages/shared/pane/BudgetGroup.vue
index ed0eb587..552fed5a 100644
--- a/src/app/pages/shared/pane/BudgetGroup.vue
+++ b/src/app/pages/shared/pane/BudgetGroup.vue
@@ -68,8 +68,8 @@ import { useI18n } from 'vue-i18n';
 import Button from '@components/base/button/Button.vue';
 import Currency from '@components/base/currency/Currency.vue';
 import CurrencyCell from '@components/base/currency-cell/CurrencyCell.vue';
+import { ReorderEvent, DraggableEvent } from '@components/base/draggable/Draggable.types';
 import Draggable from '@components/base/draggable/Draggable.vue';
-import { ReorderEvent, DraggableEvent } from '@components/base/draggable/types';
 import TextCell from '@components/base/text-cell/TextCell.vue';
 import { useDataStore } from '@store/state';
 import { BudgetGroup } from '@store/state/types';
diff --git a/src/app/pages/shared/pane/BudgetGroups.vue b/src/app/pages/shared/pane/BudgetGroups.vue
index d5e3d1dd..d4bbdb92 100644
--- a/src/app/pages/shared/pane/BudgetGroups.vue
+++ b/src/app/pages/shared/pane/BudgetGroups.vue
@@ -41,8 +41,8 @@ import { computed } from 'vue';
 import { useI18n } from 'vue-i18n';
 import Button from '@components/base/button/Button.vue';
 import Currency from '@components/base/currency/Currency.vue';
+import { DraggableEvent, ReorderEvent } from '@components/base/draggable/Draggable.types';
 import Draggable from '@components/base/draggable/Draggable.vue';
-import { DraggableEvent, ReorderEvent } from '@components/base/draggable/types';
 import { useMonthNames } from '@composables';
 import { useDataStore } from '@store/state';
 import BudgetGroup from './BudgetGroup.vue';