From 45c27603d2b1f3536eccee7bdf20b9626a128bb3 Mon Sep 17 00:00:00 2001 From: Simon Willison Date: Thu, 13 Jun 2024 10:15:38 -0700 Subject: [PATCH] xfail two flaky tests, #2355, #2356 --- tests/test_api_write.py | 1 + tests/test_csv.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/test_api_write.py b/tests/test_api_write.py index 6a7ddeb61d..2b57a99a0f 100644 --- a/tests/test_api_write.py +++ b/tests/test_api_write.py @@ -1359,6 +1359,7 @@ async def test_create_table_permissions( @pytest.mark.asyncio +@pytest.mark.xfail(reason="Flaky, see https://github.com/simonw/datasette/issues/2356") @pytest.mark.parametrize( "input,expected_rows_after", ( diff --git a/tests/test_csv.py b/tests/test_csv.py index d4c072c050..6dbe693b64 100644 --- a/tests/test_csv.py +++ b/tests/test_csv.py @@ -189,7 +189,7 @@ async def test_csv_with_non_ascii_characters(ds_client): assert response.text == "text,number\r\nšœš¢š­š¢šžš¬,1\r\nbob,2\r\n" -@pytest.mark.skip(reason="flakey") +@pytest.mark.xfail(reason="Flaky, see https://github.com/simonw/datasette/issues/2355") def test_max_csv_mb(app_client_csv_max_mb_one): # This query deliberately generates a really long string # should be 100*100*100*2 = roughly 2MB