Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: removing python 38 #1059

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wip: removing python 38 #1059

wants to merge 1 commit into from

Conversation

iparask
Copy link
Member

@iparask iparask commented Dec 4, 2024

No description provided.

@iparask iparask marked this pull request as ready for review December 4, 2024 20:39
@iparask
Copy link
Member Author

iparask commented Dec 4, 2024

This PR removes python 3.8 as a requirement for sotodlib. It increments the requirement in setup.py, removes it from the test workflow.

It also removes the deprecated setuptools.command.test and updates the test to use python -m unittest discover.

@iparask iparask linked an issue Dec 5, 2024 that may be closed by this pull request
@BrianJKoopman
Copy link
Member

I'm not really a maintainer of this repo (though I am glad to see this) so I'm going to back out of the requested review. If there are any specifics that I might be able to help with feel free to ping me.

@BrianJKoopman BrianJKoopman removed their request for review December 5, 2024 19:51
Copy link
Member

@mhasself mhasself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Farewell python 3.8. I will so miss not being able to use the | operator on dictionaries.

Wait for @tskisner approval on the TestCommand stuff -- I don't know about that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using deprecated features in setuptools
3 participants