Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need a new name for the overall mapmaking flags #1054

Open
chervias opened this issue Dec 4, 2024 · 1 comment
Open

We need a new name for the overall mapmaking flags #1054

chervias opened this issue Dec 4, 2024 · 1 comment

Comments

@chervias
Copy link
Contributor

chervias commented Dec 4, 2024

So far we have followed the ACT convention, where the flags are called glitch_flags. However, now we have a glitch-finding function that add flags named glitches, which are obviously different from the overall flags, but could lead to a conflict of names.
With overall flags for mapmaking I mean the union of turnarounds, glitches, jumps, bad subscans, etc.

@mhasself
Copy link
Member

mhasself commented Dec 4, 2024

The plan here has always been to combine various flags into two aggregate flags that mapmaking would treat slightly separately:

  • do_not_map -- data that are not completely invalid, but where there is some desire to exclude them from the map. For example, turn-arounds regions can usually be included, without any patching, when doing fourier filtering. But the samples themselves should be excluded from mapmaking. Or if there are a few places where the pointing is uncertain, but the signal otherwise well behaved.
  • invalid_signal -- data that cannot be trusted (such as glitches); these need to be gap-filled before fourier operations, and thus the samples excluded from mapmaking.

I'm open to better name suggestions here I just want to encourage a focus on how the aggregate flags will be used downstream, rather than what goes into them. (So I am quite happy to lose the "glitch_flags" hard code from the mapmakers...)
There might be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants