Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align processes in Sept 2024 Filter+Bin Mapmaker script with preprocessing module #1009

Open
8 of 9 tasks
susannaaz opened this issue Oct 17, 2024 · 1 comment
Open
8 of 9 tasks

Comments

@susannaaz
Copy link
Contributor

susannaaz commented Oct 17, 2024

This issue is to refactor the filter-bin (F+B) mapmaking script starting from the one used for the latest run of SATP3 maps (make_filterbin_map_20240924.py) to use the preprocessing module.

This involves taking away from the (F+B) script all the "on-the-fly" functions that already exist in the module and add to the preprocessing module any new functions:

  • Rotation to telescope coordinates
  • Subscan poly filtering
  • Demod common mode deprojection
  • AZSS subscan correction
  • Modified noise fitting (bounds)
  • White noise cuts - low wn, high wn, fknee
  • Apply pointing model --> used for SATP1

This will also involve:

  • Adding the option to call these functions from the preprocessing module directly inside the F+B script
  • Adding the option to write the outputs of each step into a preprocessing database and/or read directly from a preprocessing database when this exists (this partially overlaps with Sat mapmaking refactor #973)
@msilvafe
Copy link
Contributor

Just so you know @susannaaz, I believe that one part of this update is to include subscan level flags based on PSD stats per subscan @earosenberg has opened a draft PR #1028 addressing this as well as adding in the glitch detection criteria (Interquartile range) defined per subscan to reduce the number of false-positives. So you don't need to add that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants