Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When running preprocessing in LoadContext, handle detectors and samples that are removed #1004

Open
tskisner opened this issue Oct 17, 2024 · 0 comments
Assignees

Comments

@tskisner
Copy link
Member

Toast observations include all detectors and samples, and use bitflags to handle cut detectors / samples. When we run the preprocessing pipeline inside the LoadContext operator, some detectors may be removed from the axismanager and a symmetric buffer of samples on either end of the data may also be removed.

The solution is to get the detector list from the det LabelAxis and use that to map to the full detector set in the toast observation. Then data can be copied one detector at a time. Currently entire 2D blocks of detectors/samples are copied at once, which results both in incorrect ordering of detector data and also a segfault when trying to access detector indices in the axismanager which are now out of range.

For the removed samples, we can assume (?!?) that the number of samples removed is symmetric and center the array of samples in the full array while flagging the missing samples on either end.

This is the last thing holding up #943 .

@tskisner tskisner self-assigned this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant