Add start_position
argument to seq.scan()
#191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
start_position
argument toseq.scan()
. This optional argument, if passed, will move the telescope to the start position before beginning the scan.One thing to consider here is the time checking. In each scan we are checking whether the
stop_time
has already passed and whether there is enough time between "now" andstop_time
for the scan to be at leastmin_duration
. In either case we just skip the scan if there isn't enough time.Now the
stop_time
passed check happens first, then motion tostart_position
, and then we check if there's enough time left. I don't know how tight the scans could possibly be scheduled, but since we previously would already be in the correct position at the start of the scan I could potentially see an impact on whether we pass themin_duration
check given we'll be taking up some time to move that was maybe previously accounted for in the scheduler. Someone more familiar with the scheduler should comment.Resolves #190.