Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start_position argument to seq.scan() #191

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BrianJKoopman
Copy link
Member

This PR introduces the start_position argument to seq.scan(). This optional argument, if passed, will move the telescope to the start position before beginning the scan.

One thing to consider here is the time checking. In each scan we are checking whether the stop_time has already passed and whether there is enough time between "now" and stop_time for the scan to be at least min_duration. In either case we just skip the scan if there isn't enough time.

Now the stop_time passed check happens first, then motion to start_position, and then we check if there's enough time left. I don't know how tight the scans could possibly be scheduled, but since we previously would already be in the correct position at the start of the scan I could potentially see an impact on whether we pass the min_duration check given we'll be taking up some time to move that was maybe previously accounted for in the scheduler. Someone more familiar with the scheduler should comment.

Resolves #190.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add movement to starting position in seq.scan()
1 participant