Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed (most of) Issue #531 #539

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Conversation

RemingtonGerras
Copy link
Contributor

Description

  • UVI is no longer off by a factor of 10 (divided by 10)
  • UVI overflow issue is fixed by adding 2**7 to negative (overflowed) values
  • Changed temperature from Fahrenheit to Celsius

Motivation and Context

Issue #531

How Has This Been Tested?

I ran python in terminal and created functions that take dummy input values and output the changed value.
These functions reflected the changes I made in the agent.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

There are comments in code that should be changed (instances of 'fahrenheit' to 'celsius')

Copy link
Member

@mhasself mhasself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, UV fix looks good. Please use function for F_to_C. It is then self-documenting and less prone to little typos.

socs/agents/vantagepro2/drivers.py Outdated Show resolved Hide resolved
@BrianJKoopman BrianJKoopman merged commit e021f7a into main Oct 11, 2023
2 checks passed
@BrianJKoopman BrianJKoopman deleted the vantage-uvi-and-temp-readout branch October 11, 2023 17:40
mhasself pushed a commit that referenced this pull request Oct 16, 2023
* Address Issue #531

* Correct UVI overflow calculation

* Write fahrenheit to celsius conversion function to use when collecting temperature data

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
hnakata-JP pushed a commit that referenced this pull request Apr 12, 2024
* Address Issue #531

* Correct UVI overflow calculation

* Write fahrenheit to celsius conversion function to use when collecting temperature data

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants