Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes within agents run with create_agent_runner_fixture cause tests to hang #398

Closed
BrianJKoopman opened this issue Aug 1, 2024 · 0 comments · Fixed by #401
Closed
Assignees
Labels
bug Something isn't working

Comments

@BrianJKoopman
Copy link
Member

This was seen in a recent socs PR: simonsobs/socs#686

A crash within the Agent doesn't bring the agent down, but hold up the tests, hanging until killed either by the user or by GitHub Actions after 6 hours.

A configurable timeout should be added that'll raise an error for the given test and move on. This should be possible with subprocess.run() in place of subprocess.Popen().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant