Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cordinate with pluggy wrt upstream integration of async #50

Open
RonnyPfannschmidt opened this issue Aug 16, 2024 · 4 comments
Open

cordinate with pluggy wrt upstream integration of async #50

RonnyPfannschmidt opened this issue Aug 16, 2024 · 4 comments

Comments

@RonnyPfannschmidt
Copy link

hi, im one of the maintainers of pluggy
im planning to add upstream async support, this will likely break this library as is

@TaiSakuma
Copy link
Member

Ok. Thank you for letting me know.

If pluggy supports all extra features that this package adds, this package can be unnecessary.

The extra features are

  • Async support
  • Context manager support
    • with send, throw, and close support (Undocumented in READEME.md)
  • Async context manager support
    • with asend, athrow, and aclose support (Undocumented in READEME.md)
  • Accept a class (not only a class instance) for registration

@RonnyPfannschmidt
Copy link
Author

Async support is certain

The context Manager details for call/hooks will need some analysis, at first glance im -1 on it

Type instead of instance is one of those slippy slopes between easy and simple, I'm -0 on it ATM

I think I need more practical examples of the context Manager usages as the toy examples don't bring a use to mind where I wouldn't use hookwappers

@TaiSakuma
Copy link
Member

That sounds great.

I will try to think if it is possible to rewrite my usage of context managers with hook wrappers.

@RonnyPfannschmidt
Copy link
Author

as far as i can tell, the context managers are a very slippery slope - first he hook runs, then the managers are entered - that workflow is terrifying to me as there wil lbe actions at a distance if the context manager is not entered while the hook is running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants