From b93acfd75edd34f43c82a85183b67a166cf5163a Mon Sep 17 00:00:00 2001 From: Simon Puente Date: Sun, 17 Jul 2022 10:09:57 -0700 Subject: [PATCH 1/8] refactor(notevalidator): Run ts-standard --fix --- src/NoteValidator.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/NoteValidator.ts b/src/NoteValidator.ts index 0690d37..6ee72f3 100644 --- a/src/NoteValidator.ts +++ b/src/NoteValidator.ts @@ -1,7 +1,6 @@ export class NoteValidator { - isValid(note: string): boolean { - if(note < 'A' || note > 'G') - return false + isValid (note: string): boolean { + if (note < 'A' || note > 'G') { return false } return true } } From 353be02b441fda69fdb3532b39dcf631abf59d10 Mon Sep 17 00:00:00 2001 From: simonppg Date: Tue, 12 Sep 2023 19:25:56 -0700 Subject: [PATCH 2/8] Add enter --- src/NoteValidator.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/NoteValidator.ts b/src/NoteValidator.ts index 6ee72f3..f5186bd 100644 --- a/src/NoteValidator.ts +++ b/src/NoteValidator.ts @@ -1,4 +1,5 @@ export class NoteValidator { + isValid (note: string): boolean { if (note < 'A' || note > 'G') { return false } return true From 929ca59d6d6a7f8088a14da9eecac405dff1a408 Mon Sep 17 00:00:00 2001 From: simonppg Date: Tue, 12 Sep 2023 19:37:38 -0700 Subject: [PATCH 3/8] Remove enter --- src/NoteValidator.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/NoteValidator.ts b/src/NoteValidator.ts index f5186bd..6ee72f3 100644 --- a/src/NoteValidator.ts +++ b/src/NoteValidator.ts @@ -1,5 +1,4 @@ export class NoteValidator { - isValid (note: string): boolean { if (note < 'A' || note > 'G') { return false } return true From 0f47115e13ca5c9b42b60e506ada7d6cc52014ab Mon Sep 17 00:00:00 2001 From: Simon Puente Date: Tue, 12 Sep 2023 19:43:27 -0700 Subject: [PATCH 4/8] Create .eslintrc.yml --- .eslintrc.yml | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 .eslintrc.yml diff --git a/.eslintrc.yml b/.eslintrc.yml new file mode 100644 index 0000000..1045911 --- /dev/null +++ b/.eslintrc.yml @@ -0,0 +1,8 @@ +env: + es6: true + browser: true + node: true + +parserOptions: + project: ["./tsconfig.json"] + createDefaultProgram: true From c21f1e5ba6c56d07996fbca8fb4e5e73682fcfac Mon Sep 17 00:00:00 2001 From: Simon Puente Date: Tue, 12 Sep 2023 19:49:09 -0700 Subject: [PATCH 5/8] Update super-linter.yml --- .github/workflows/super-linter.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/super-linter.yml b/.github/workflows/super-linter.yml index 6ab998c..32e1173 100644 --- a/.github/workflows/super-linter.yml +++ b/.github/workflows/super-linter.yml @@ -28,3 +28,5 @@ jobs: DEFAULT_BRANCH: main GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} FILTER_REGEX_EXCLUDE: .*tests/.* + JAVASCRIPT_ES_CONFIG_FILE: .eslintrc.yml + TYPESCRIPT_ES_CONFIG_FILE: .eslintrc.yml From 923f4ca6af0b49d8ff3b71c0d8e828f63c734f96 Mon Sep 17 00:00:00 2001 From: Simon Puente Date: Tue, 12 Sep 2023 19:54:23 -0700 Subject: [PATCH 6/8] Update .eslintrc.yml --- .eslintrc.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.eslintrc.yml b/.eslintrc.yml index 1045911..4d66758 100644 --- a/.eslintrc.yml +++ b/.eslintrc.yml @@ -1,3 +1,4 @@ +--- env: es6: true browser: true From 2ef7a914137e2dbe0ddf3ea9831368356c77b888 Mon Sep 17 00:00:00 2001 From: Simon Puente Date: Tue, 12 Sep 2023 20:04:17 -0700 Subject: [PATCH 7/8] Update tsconfig.json --- tsconfig.json | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tsconfig.json b/tsconfig.json index 64c3dc9..86b24b9 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -8,7 +8,10 @@ "esModuleInterop": true, "forceConsistentCasingInFileNames": true, "strict": true, - "skipLibCheck": true + "skipLibCheck": true, + "rootDirs": [ + "src/**/*" + ] }, "include": [ "src/**/*" From 5947e1ca6816810a162a55b55560f62855c38a2f Mon Sep 17 00:00:00 2001 From: Simon Puente Date: Tue, 12 Sep 2023 20:13:21 -0700 Subject: [PATCH 8/8] Update NoteValidator.ts --- src/NoteValidator.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/NoteValidator.ts b/src/NoteValidator.ts index 6ee72f3..0690d37 100644 --- a/src/NoteValidator.ts +++ b/src/NoteValidator.ts @@ -1,6 +1,7 @@ export class NoteValidator { - isValid (note: string): boolean { - if (note < 'A' || note > 'G') { return false } + isValid(note: string): boolean { + if(note < 'A' || note > 'G') + return false return true } }