-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark /metric-payload-options optional in docs #622
Comments
👋🏾 can you send PR with a fix? I believe it is in QueryBuilderPayloadSelect |
So we want to follow a) the docs and skip the request or b) just update the docs to mention the request will be made anyways, but a 404 is fine? |
I think the datasource should not make the request as stated in the docs now (?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I recently implemented the endpoints, but missed the
/metric-payload-options
endpoint (thus serving a 404). The docs state this endpoint is requested to fill the payload options, if they are empty, but I am still seeing requests to this endpoint even though I always serve the options when describing the available metrics.It feels like the docs are a bit inconsistent from what I am seeing:
a) It doesn't seem to actually be required since it works just fine as I am serving a 404 and provide the options in the initial metrics structure
b) The docs state this is only requests if the options are empty, but I am still seeing requests
The text was updated successfully, but these errors were encountered: