Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark /metric-payload-options optional in docs #622

Open
zeisss opened this issue Aug 16, 2024 · 3 comments
Open

Mark /metric-payload-options optional in docs #622

zeisss opened this issue Aug 16, 2024 · 3 comments

Comments

@zeisss
Copy link

zeisss commented Aug 16, 2024

When the payload type is select or multi-select and the payload options configuration is empty, expanding the drop-down menu will trigger this API. The request body will carry the current metric and payload.

I recently implemented the endpoints, but missed the /metric-payload-options endpoint (thus serving a 404). The docs state this endpoint is requested to fill the payload options, if they are empty, but I am still seeing requests to this endpoint even though I always serve the options when describing the available metrics.

It feels like the docs are a bit inconsistent from what I am seeing:
a) It doesn't seem to actually be required since it works just fine as I am serving a 404 and provide the options in the initial metrics structure
b) The docs state this is only requests if the options are empty, but I am still seeing requests

@simPod
Copy link
Owner

simPod commented Sep 10, 2024

👋🏾 can you send PR with a fix? I believe it is in QueryBuilderPayloadSelect

@zeisss
Copy link
Author

zeisss commented Sep 23, 2024

So we want to follow a) the docs and skip the request or b) just update the docs to mention the request will be made anyways, but a 404 is fine?

@simPod
Copy link
Owner

simPod commented Sep 27, 2024

I think the datasource should not make the request as stated in the docs now (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants