You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
a variety of context changes in each locale both saved as draft and published
changed_enabled config set to true
When viewing the version feed history for a page across locales, the changes returned are always from a single locale.
I notice that the logic in this module largely constructs raw SQL queries, which Fluent will not be able to modify - for example:
// This can leak secured content if it was protected via inherited setting.// For now the users will need to be aware about this shortcoming.$offset = $highestVersion ? "AND \"SiteTree_Versions\".\"Version\"<='".(int)$highestVersion."'" : '';
// Get just enough elements for diffing. We need one more than desired to have something to compare to.$qLimit = (int)$limit + 1;
$versions = $this->owner->allVersions(
"\"WasPublished\"='1' AND \"CanViewType\" IN ('Anyone', 'Inherit') $offset",
"\"SiteTree\".\"LastEdited\" DESC, \"SiteTree\".\"ID\" DESC",
$qLimit
);
We need to rewrite the parts of raw SQL in this module to use the ORM so that other modules like Fluent can update queries as required.
The text was updated successfully, but these errors were encountered:
Context: CWP 2.0.0, SilverStripe 4.1.1, Versionfeed 2.x-dev, Fluent 4.0.x-dev
Set up:
When viewing the version feed history for a page across locales, the changes returned are always from a single locale.
I notice that the logic in this module largely constructs raw SQL queries, which Fluent will not be able to modify - for example:
We need to rewrite the parts of raw SQL in this module to use the ORM so that other modules like Fluent can update queries as required.
The text was updated successfully, but these errors were encountered: