Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate if replacing RateLimitFilter could be replaced by Core features #50

Open
NightJar opened this issue Dec 14, 2017 · 2 comments
Open

Investigate if replacing RateLimitFilter could be replaced by Core features #50

NightJar opened this issue Dec 14, 2017 · 2 comments
Labels
affects/v4 complexity/low impact/low rfc/accepted type/api-break
Milestone
Cleanup later

Comments

@NightJar
Copy link
Contributor

SilverStripe Framework provides us SilverStripe\Core\Cache\RateLimiter which may (or may not) provide the same service for less code. It'd mean less maintenance too. Is it possible to make the replacement?
@robbieaverill
Copy link
Contributor

I think this is a sensible idea

@dhensby
Copy link
Contributor

dhensby commented Dec 14, 2017

It should be straightforward to apply the RateLimitMiddleware to the VersionFeedController which would do away with the need for your own rate limiter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/low impact/low rfc/accepted type/api-break
Projects
None yet
Milestone
Cleanup later
Development

No branches or pull requests
4 participants
@dhensby @NightJar @robbieaverill @GuySartorelli