Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching between pages should reset comparison mode #143

Open
timkung opened this issue Jan 7, 2020 · 0 comments
Open

Switching between pages should reset comparison mode #143

timkung opened this issue Jan 7, 2020 · 0 comments

Comments

@timkung
Copy link

timkung commented Jan 7, 2020

It looks like when you enter the comparison mode when viewing history of a Page, it keeps the state of which versions are being compared as well as the comparison mode being toggled on.

This can cause an issue where you compare versions of a Page, and then switch to view the history of another Page which doesn't have the same versions as the previous Page and this causes a 404 (and broken UI), as it automatically calls the following URL as soon as you click on the History tab: /admin/historyviewer/schema/compareForm/<page-id>?RecordVersionFrom=<previous-from-version-id>&RecordVersionTo=<previous-to-version-id>&RecordClass=Page&RecordID=<page-id>

Steps to reproduce:

  1. Create 2 new Pages
  2. Create 4 versions on one of those Pages
  3. Go to the History tab for the Page with 4 versions
  4. Toggle the comparison mode and select version 4 and 3
  5. Go to the second page
  6. Click the History tab
  7. See 404 error

Found using version 1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants