-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BulkActions
CSS issue with checkboxes under the "Submissions" section
#1291
Comments
Do you know if this is still an issue in 6.2 of the module in CMS 5? |
Nope, didn't have a chance to sorry, our codebase is still running on CMS 4, so could only go as high as |
@GuySartorelli says there's another issue to handle the other two CSS inconsistencies. So we just need to deal with the checkboxes. |
|
There is no "BulkActions" css class nor any associated checkboxes in this module nor in @pjayme You ticked the "Double check that your reproduction steps work in a fresh installation of silverstripe/installer" checkbox.... but you haven't provided reproduction steps that will introduce the checkboxes. Please provide all of the information required to reproduce this bug. |
@GuySartorelli ah I had thought this was all part of the module but indeed on second look it looks like the Another thing to note is that |
Thanks for that extra detail. I'll look into this. In this case since |
Linked PR has been merged, it will be automatically tagged shortly. Note that it's fixed on the 4.0 branch which is for CMS 5 |
Module version(s) affected
5.15
Description
There is a misalignment with the positioning of the checkboxes associated to the
BulkActions
component which reveals itself when the viewport height of the browser window is not high enough to display a list of records from theGridField
:How to reproduce
UserDefinedForm
with some basic fieldsBulkAction
checkboxes act like they are "floating" and therefore cause misalignment against the rows of theGridField
Possible Solution
We have gotten around this issue by introducing our own stylesheet for the CMS and targeting the breaking element. We assume this issue applies to all
BulkAction
components but in our case we have restricted it to the "Submissions" area of the UserDefinedForms to prevent any further regressions.In
cms.css
:Acceptance criteria
The first user field is not chopped offThe history table does is flush with the main areaAdditional Context
No response
Validations
silverstripe/installer
(with any code examples you've provided)PRs
The text was updated successfully, but these errors were encountered: