Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringTagField should not write record in saveInto #119

Closed
iqmeckert opened this issue Sep 19, 2018 · 3 comments
Closed

StringTagField should not write record in saveInto #119

iqmeckert opened this issue Sep 19, 2018 · 3 comments

Comments

@iqmeckert
Copy link

iqmeckert commented Sep 19, 2018

In class StringTagField, the method saveInto() should not write the data record. Validation will take place before all values are pushed to the DataObject, therefore throwing false validation errors.

Also, should remove empty values or zeros when used as "not multiple"

@robbieaverill
Copy link
Contributor

Which version are you using please?

@iqmeckert
Copy link
Author

According to the changelog, I'm using version 1.3.0 in SS 4.1.2, but I see the code is the same in the latest version. I'm using StringTagField because the field I'm setting is on the same record, where it looks like TagField requires a relational object

@robbieaverill
Copy link
Contributor

I think this is a duplicate of #79 - feel free to reopen if you disagree @iqmeckert =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants