You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Previously started as a feature, it seems as though the intention was to have a handler that would return a list, and a handler that would return a singular item (perhaps with relations). Routes could be set up for each type of condition, and the code as a whole would become much more readable as it reduces the number of conditionals on whether or not we have a SS_List or a DataObject.
During the migration from SS3 support to SS4, the commented code and @todo items covering this were removed. This issue encapsulates the idea behind them, as I thought it seemed like a sensible idea.
The text was updated successfully, but these errors were encountered:
@NightJar do you think this should be done in the 2.0.0 milestone? It looks like those classes exist already, so if we can do this without breaking any APIs then it could be done after 2.0.0 as a minor release?
They did exist, but were removed as part of the upgrade as were essentially dead code.
We could leave the class files there, sure. I don't think the restructure work is a thing for now though.
We could restructure the module later quite easily, as the API wouldn't change I think - only the responsibilities of the methods within (the current RestfulServer class).
Overall post restructure the functionality would be the same. But ultimately if it means tagging a 3.0 then is there some blocker as to why this couldn't happen?
I think in actuality we'd be introducing features, which at most would only be a minor release.
Previously started as a feature, it seems as though the intention was to have a handler that would return a list, and a handler that would return a singular item (perhaps with relations). Routes could be set up for each type of condition, and the code as a whole would become much more readable as it reduces the number of conditionals on whether or not we have a
SS_List
or aDataObject
.During the migration from SS3 support to SS4, the commented code and @todo items covering this were removed. This issue encapsulates the idea behind them, as I thought it seemed like a sensible idea.
The text was updated successfully, but these errors were encountered: