Link as Required Field doesn't appear to work

[chrispenny]

class MyBlock extends BaseElement
{
    private static array $has_one = [
        'CtaLinkPrimary' => Link::class,
    ];

    private static bool $inline_editable = false;

    public function getCMSFields(): FieldList
    {
        $fields = parent::getCMSFields();

        $fields->addFieldsToTab(
            'Root.Main',
            [
                TextField::create('Title'),
                LinkField::create('CtaLinkPrimary'),
            ]
        );

        return $fields;
    }

    public function getCMSCompositeValidator(): CompositeValidator
    {
        $composite = parent::getCMSCompositeValidator();

        $composite->addValidator(RequiredFields::create([
            'Title',
            'CtaLinkPrimaryID',
            // Also tried:
            'CtaLinkPrimary',
        ]));

        return $composite;
    }
}

Result

Title field correctly displays error, but LinkField does not.

PRs

• NEW HasOneRelationFieldInterface silverstripe-framework#11119
• Fix RequiredFields validation #195
• MNT Remove unused import silverstripe-framework#11122

[GuySartorelli]

That's quite possibly a problem with RequiredFields rather than with linkfield. I imagine you'd get the same result if you were using https://github.com/silvershop/silverstripe-hasonefield and tried to set a HasOneField's value as required.

[sabina-talipova]

Hi @chrispenny,
I don't know, but probably it could helps to find some idea. I add new class that extends LinkField's FormFactory and implements getValidator(). Please, see test steps in this PR.

[maxime-rainville]

We'll validate if this is still a problem and fix it if it is.

[GuySartorelli]

PRs merged