Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkField needs fluent's gridfield removed so modal renders #243

Closed
emteknetnz opened this issue Mar 3, 2024 · 1 comment
Closed

LinkField needs fluent's gridfield removed so modal renders #243

emteknetnz opened this issue Mar 3, 2024 · 1 comment
Assignees
Labels

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Mar 3, 2024

Fluent will add a tab with a gridfield to linkfield, however because there is no react component for gridfield, you'll get a hard error on the frontend and the link modal will not work at all

To work around this on the SPIKE added a workaround protected $schemaDataType = self::SCHEMA_DATA_TYPE_STRUCTURAL;, though this shouldn't be merged as the lack of a gridfield component should hard fail so that developers are prompted to remove gridfields

Acceptance criteria

  • When fluent is installed, the tab with the gridfield is removed so that it does not render in the link modal

PR

@emteknetnz emteknetnz changed the title Fluent needs gridfield remove to render modal Fluent needs gridfield removed so modal renders Mar 3, 2024
@GuySartorelli GuySartorelli changed the title Fluent needs gridfield removed so modal renders LinkField needs fluent's gridfield removed so modal renders Mar 7, 2024
@emteknetnz emteknetnz self-assigned this Mar 7, 2024
@emteknetnz emteknetnz removed their assignment Mar 7, 2024
@GuySartorelli
Copy link
Member

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants