[I18N] Fix all instances of incorrect translation syntax

[robbieaverill]

Affected Version

SilverStripe 4.x

Description

When running the text collector there are a lot of strings that throw errors and are ignored. We have an open issue to support SomeClass::class syntax in translations, but until that is completed we should fix the existing translations.

Steps to Reproduce

• Run vendor/bin/sake dev/tasks/i18nTextCollectorTask '' flush=1
• See a tonne of errors
• Check and notice that the examples that cause errors don't make it into framework/lang/en.yml as source strings

Pull requests

• FIX Text collector translations now compile without errors #8357
• FIX Text collector translations now compile without errors silverstripe-siteconfig#100
• FIX Text collector translations now compile without errors silverstripe-versioned-admin#58

[robbieaverill]

PRs added that fix a relatively vanilla 4.3 install. I'll sanity check the wider CWP modules too.

[robbieaverill]

Ok follow up PRs for CWP and Fluent are up.

It'd be nice to display translation errors in a nice way rather than having a screen full of exception stack traces, and also to exit with a non-zero exit code when they happen so that we could put this into CI. I had a brief look at both of these. We can only really get the warning message e.g. "missing translation key for X" but in doing this we lose all of the stack trace context, which is actually more useful in this task. Re: exiting with non-zero exit codes, we can do this too but we also lose the exception context by defining a new error handler.

TL;DR: wait until we have a proper CLI in place, then we can redesign text collection generally. Related: #5542

[kinglozzer]

PRs all merged, closing as root cause is tracked in #7647

[robbieaverill]

Cheers =)