Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Restrict access to getJobStatus execution #113

Conversation

sabina-talipova
Copy link

Description

  • Added verification of user access to the CMS and limited the ability to execute a request to getJobStatus and start.
  • Added error handling on the client.

Parent issue

@sabina-talipova sabina-talipova marked this pull request as draft November 8, 2023 02:54
@sabina-talipova sabina-talipova marked this pull request as ready for review November 8, 2023 02:55
src/Controllers/CMSExternalLinksController.php Outdated Show resolved Hide resolved
src/Controllers/CMSExternalLinksController.php Outdated Show resolved Hide resolved
src/Controllers/CMSExternalLinksController.php Outdated Show resolved Hide resolved
tests/php/ExternalLinksTest.php Outdated Show resolved Hide resolved
tests/php/ExternalLinksTest.php Outdated Show resolved Hide resolved
tests/php/ExternalLinksTest.php Outdated Show resolved Hide resolved
tests/php/ExternalLinksTest.php Outdated Show resolved Hide resolved
tests/php/ExternalLinksTest.php Outdated Show resolved Hide resolved
client/javascript/BrokenExternalLinksReport.js Outdated Show resolved Hide resolved
client/javascript/BrokenExternalLinksReport.js Outdated Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/2.4/restrict-access-getjob-status branch 2 times, most recently from 3df0927 to 02b3b79 Compare November 8, 2023 19:16
src/Controllers/CMSExternalLinksController.php Outdated Show resolved Hide resolved
src/Controllers/CMSExternalLinksController.php Outdated Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/2.4/restrict-access-getjob-status branch from 02b3b79 to 0ea5dec Compare November 8, 2023 20:47
@emteknetnz emteknetnz merged commit 8797f1f into silverstripe:2.4 Nov 8, 2023
11 checks passed
@emteknetnz emteknetnz deleted the pulls/2.4/restrict-access-getjob-status branch November 8, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants