FIX Set empty date to null

silverstripe · Oct 25, 2024 · 8622bbe · 8622bbe
1 parent cd1b9ed
commit 8622bbe
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/Extensions/SiteTreeContentReview.php b/src/Extensions/SiteTreeContentReview.php
@@ -194,7 +194,7 @@ protected function updateCMSActions(FieldList $actions)
      *
      * @param SiteTree $page
      *
-     * @return bool|DBDate
+     * @return null|DBDate
      */
     public function getReviewDate(SiteTree $page = null)
     {
@@ -209,11 +209,11 @@ public function getReviewDate(SiteTree $page = null)
         $options = $this->owner->getOptions();
 
         if (!$options) {
-            return false;
+            return null;
         }
 
         if (!$options->ReviewPeriodDays) {
-            return false;
+            return null;
         }
 
         // Failover to check on ReviewPeriodDays + LastEdited
@@ -508,7 +508,6 @@ public function advanceReviewDate()
                 ' + ' . $options->ReviewPeriodDays . ' days',
                 DBDatetime::now()->getTimestamp()
             );
-
             $this->owner->NextReviewDate = DBDate::create()->setValue($nextDateTimestamp)->Format(DBDate::ISO_DATE);
             $this->owner->write();
         }
@@ -662,6 +661,8 @@ protected function setDefaultReviewDateForInherited()
 
         if (is_object($nextDate)) {
             $this->owner->NextReviewDate = $nextDate->getValue();
+        } elseif ($nextDate === false) {
+            $this->owner->NextReviewDate = null;
         } else {
             $this->owner->NextReviewDate = $nextDate;
         }