Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session manager - namespaces are seemingly incorrect #54

Open
LiamKearn opened this issue Jun 16, 2023 · 0 comments
Open

Session manager - namespaces are seemingly incorrect #54

LiamKearn opened this issue Jun 16, 2023 · 0 comments

Comments

@LiamKearn
Copy link

Looking at this commit of auditor: https://github.com/silverstripe/silverstripe-auditor/tree/3e7365cc746000762c08c292f140b2f46df20922

And it's CI job with silverstripe/session-manager installed: https://github.com/silverstripe/silverstripe-auditor/actions/runs/4878200297/jobs/8703966002

You can see in the above CI job that commit f31d851 of silverstripe/session-manager is being used. You can also see lastpass but let's not talk about that..
Screenshot 2023-06-16 at 7 46 56 pm

In commit f31d851 a LoginSession is under the namespace SilverStripe\SessionManager\Models however in the commit in this module that triggered the run LoginSession is used as a parameter type hint and referred to as SilverStripe\SessionManager\Model\LoginSession (Model not Models).

I'd expect a type exception given that SilverStripe\SessionManager\Model\LoginSession does not exist in silverstripe/session-manager at commit f31d851.

Might be something, might not 🤷🏻‍♂️ 😀


I only briefly glanced at this list but it sounds like some of these are genuine bugs - are there issues for them?

@GuySartorelli CC since I think this is what you were asking for (splitting out from #53)?

@LiamKearn LiamKearn changed the title Session manager namespaces are seemingly incorrect Session manager - namespaces are seemingly incorrect Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants