Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling for code links in docs is sub-optimal #254

Open
3 tasks
GuySartorelli opened this issue Feb 8, 2023 · 0 comments
Open
3 tasks

Styling for code links in docs is sub-optimal #254

GuySartorelli opened this issue Feb 8, 2023 · 0 comments
Labels

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Feb 8, 2023

Identified during https://github.com/silverstripeltd/product-issues/issues/627
The colour of the underline for code blocks inside links is blue, but the background and text colour for those code blocks is grey. It looks a little odd.
Also, links inside code blocks are not consistent styled with code blocks inside links.

Acceptance Criteria

Notes

  • While playing around, Steve and Guy each came up with how we think it should look. Use best judgment or get a designer to opine.
    • Steve's suggestion:
    background-color: #005ae114;
    color: #005AE1;
    • Guy's suggestion:
    background-color: #eef;
    color: #545E6F;

PR

#253

@GuySartorelli GuySartorelli changed the title Styling for code links is sub-optimal Styling for code links in docs is sub-optimal Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants