Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub token gets output to terminal during publish step #237

Closed
1 task done
emteknetnz opened this issue Feb 9, 2023 · 1 comment
Closed
1 task done

GitHub token gets output to terminal during publish step #237

emteknetnz opened this issue Feb 9, 2023 · 1 comment
Assignees
@GuySartorelli
Labels
impact/low type/enhancement

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Feb 9, 2023 •
edited by GuySartorelli
Loading

When running the publish step, the GitHub API token used by composer is output to the terminal

This could lead it to being accidentally shared if someone copy pastes a terminal output

I think this method may be responsible, though I haven't tested to verify

https://github.com/silverstripe/cow/blob/master/src/Utility/Composer.php#L119

Acceptance criteria

  • GitHub token are suppressed from COW output.

PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
impact/low type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli