Parsed Dictionary Attributes for writing systems #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #676 Split parseInterfacelanguage into three functions and modified index.d.ts as well as the Dictionary Config function
chrisvire
reviewed
Nov 18, 2024
convert/convertConfig.ts
Outdated
| if (inputButtonsTag) { | ||
| inputButtons = inputButtonsTag.textContent | ||
| ?.split(/\s+/) | ||
| .filter((button) => button); |
There was a problem hiding this comment.
These .filter calls are not needed.
aidanpscott
pushed a commit
that referenced
this pull request
Nov 22, 2024
* Parsed Dictionary Attributes for writing systems Issue #676 Split parseInterfacelanguage into three functions and modified index.d.ts as well as the Dictionary Config function * Ran Formatting for convertConfig Issue #676 * Revert "Ran Formatting for convertConfig" This reverts commit 842d5e5. * Ran npm format for convertConfig Issue #676 * Simplify parsing lists of chars --------- Co-authored-by: Chris Hubbard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #676
Split parseInterfacelanguage into three functions
and modified index.d.ts as well as the Dictionary
Config function