Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB user operation pool #8

Closed
Vid201 opened this issue Nov 23, 2022 · 6 comments
Closed

DB user operation pool #8

Vid201 opened this issue Nov 23, 2022 · 6 comments
Assignees

Comments

@Vid201
Copy link
Member

Vid201 commented Nov 23, 2022

Use mdbx.

@zsluedem zsluedem self-assigned this Jan 17, 2023
@zsluedem
Copy link
Collaborator

@Vid201 Hello Vid. I am just curious about why you chose mdbx here? Is it because akula is using it?
Did you consider some other options like https://docs.rs/lmdb/latest/lmdb/, https://docs.rs/rocksdb/latest/rocksdb/ or https://docs.rs/leveldb/latest/leveldb/ ?
And Reth is using its own wrapper https://github.com/paradigmxyz/reth/tree/main/crates/storage/libmdbx-rs with more free liscense.

@Vid201
Copy link
Member Author

Vid201 commented Jan 17, 2023

@Vid201 Hello Vid. I am just curious about why you chose mdbx here? Is it because akula is using it? Did you consider some other options like https://docs.rs/lmdb/latest/lmdb/, https://docs.rs/rocksdb/latest/rocksdb/ or https://docs.rs/leveldb/latest/leveldb/ ? And Reth is using its own wrapper https://github.com/paradigmxyz/reth/tree/main/crates/storage/libmdbx-rs with more free liscense.

The main (and only) reason at that time was Akula used that one.

I think it would be best to analyze other options before diving into the specifics (for example, I heard good things about rocksdb). The choice is still open.

Now that Akula is deprecated, it would make sense to explore more what Reth is using (should be similar). If one of the goals is to have tighter integration of bundler into execution client (which would have several advantages, such as faster reads and insights into Ethereum world state, shorter/direct calls to execution client functions instead of RPC API), it would be easier to use same DB type (or lib) as the execution client IMO.

@zsluedem
Copy link
Collaborator

https://github.com/ledgerwatch/erigon/wiki/Choice-of-storage-engine why erigon choose mdbx

@zsluedem
Copy link
Collaborator

@gakonst Hi. I am reviewing the database engine in reth now and I came into this comment you said in paradigmxyz/reth#377 (comment) that reth is going to switch into a pure rust db redb. I am wondering if you could share your plan about the timeline with me on this.

@gakonst
Copy link

gakonst commented Jan 18, 2023

No plan yet, we're open to using the best db for our needs. We'll benchmark first and then compare and then decide.

@zsluedem
Copy link
Collaborator

Done in #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants