Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a debug api flag for bundler api #72

Closed
zsluedem opened this issue Mar 11, 2023 · 2 comments · Fixed by #73
Closed

Provide a debug api flag for bundler api #72

zsluedem opened this issue Mar 11, 2023 · 2 comments · Fixed by #73
Assignees

Comments

@zsluedem
Copy link
Collaborator

I want to continue the question #43 (comment) here.

Currently, our debug API is config with a compiling flag #[cfg(debug_assertions)] which means the debug api would be there only when we build with cargo build. If we want to build with release version cargo build --release with compiler optimization, there are no debug apis.

I suggest we using the method like geth does providing a flag like --api debug to enable debug api instead of put it as a compilation flag. In that way, we could use release version to run tests especially for https://bundler-test-results.eip4337.com/. (BTW, @Vid201 very great job on it.) I want to see whether we could beat stackup-bundler on performance.

@Vid201 What do you think?

@Vid201
Copy link
Member

Vid201 commented Mar 11, 2023

Agree 100 % percent.

After some testing and thinking about that, I agree it's better to add additional flag like geth to enable certain API endpoints.

@Vid201
Copy link
Member

Vid201 commented Mar 11, 2023

And we can provide two packages on the repo - one with enabled debug api (for testing) and one without.

@Vid201 Vid201 self-assigned this Mar 11, 2023
@Vid201 Vid201 linked a pull request Mar 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants