-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking changes v13 - labels as arguments considered as object #499
Comments
I don't think I understand what the use case and expectation are here. |
Yes. The new code checks if the type of the first argument is an object but it returns true for array also. |
This was undocumented and untested, and broke in 13.1.0. Fixes #499
This was undocumented and untested, and broke in 13.1.0. Fixes #499
Hi,
When I'm setting labels as arguments and the first argument is an array:
it is considered as an object and throws
Added label "0" is not included in initial labelset
.I found that there is a condition
if (typeof args[0] === 'object')
but it might also check that it is not an array.I've upgraded from v12 to v14 (but it happens in v13 also).
Thanks
The text was updated successfully, but these errors were encountered: