Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--offline should warn when the trust root is unreasonably old #1175

Open
woodruffw opened this issue Oct 15, 2024 · 1 comment
Open

--offline should warn when the trust root is unreasonably old #1175

woodruffw opened this issue Oct 15, 2024 · 1 comment
Labels
component:tuf TUF related components component:verification Core verification functionality enhancement New feature or request

Comments

@woodruffw
Copy link
Member

--offline disables all possible online operations, including routine TUF trust root updates. This is desirable for offline environments where trust is pre-established or established asynchronously, but can result in users having very stale trust roots without realizing it (meaning they may be missing revocations or important rotations that allow them to verify new signatures):

Fixing this has two parts:

  1. Determine an "acceptable" oldness policy. Considering trust roots "stale" after 24h might be reasonable, but might also be too noisy for some offline users.
  2. Emit a warning when performing sigstore verify commands in --offline mode with a trust root that's older than the window chosen in (1).

From (2), there's maybe a (3): pick a "red line" after which the warning becomes a hard error, forcing the user to update. Maybe 24h for a warning and 1 week for the red line, although again this could use user/integrator feedback.

CCing @mgorny @sethmlarson for thoughts!

@woodruffw woodruffw added enhancement New feature or request component:verification Core verification functionality component:tuf TUF related components labels Oct 15, 2024
@woodruffw
Copy link
Member Author

On a related note: sigstore-python currently tried to refresh the TUF root every time it's called, which is both slow (especially when looped over in a shell script) and also overkill. It should probably refresh a maximum of once per every 15 minutes or similar, just to avoid pointlessly hammering the TUF repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:tuf TUF related components component:verification Core verification functionality enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant