Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support trusted root in cosign verification #3854

Closed
wants to merge 4 commits into from
Closed

Support trusted root in cosign verification #3854

wants to merge 4 commits into from
+601 −299

Commits on Sep 23, 2024

  1. For sigstore#3700: support trusted root in cosign verification 

    We recently added partial trusted root support to cosign when you are
verifying a protobuf bundle, but this did not cover the case where you
aren't using a bundle.

This implements trusted root support for those cases by assembling the
disparate signed material into a bundle, fixing some TODOs from when we
added protobuf bundle support.

Signed-off-by: Zach Steindler <[email protected]>
    @steiza
    steiza committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    140de08 View commit details
    Browse the repository at this point in the history

  2. Add happy path testing to cmd/cosign/cli/verify/verify_bundle.go 

    Also remove fix that is being handled in sigstore#3877

Signed-off-by: Zach Steindler <[email protected]>
    @steiza
    steiza committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d38c01b View commit details
    Browse the repository at this point in the history

  3. Reorganizing verify_bundle.go based on pull request feedback 

    Also align with sigstore#3879

Signed-off-by: Zach Steindler <[email protected]>
    @steiza
    steiza committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d3222ee View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Use custom predicate type that cosign will not modify 

    Signed-off-by: Zach Steindler <[email protected]>
    @steiza
    steiza committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    97d9ca6 View commit details
    Browse the repository at this point in the history