Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rekor spec #27

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Add rekor spec #27

merged 2 commits into from
Nov 21, 2024

Conversation

tracymiranda
Copy link

Summary

Migrate https://docs.google.com/document/d/1NQUBSL9R64_vPxUEgVKGb0p81_7BVZ7PQuI078WFn-g/edit to github

  • Add intro section
  • Make consistent with other spec doc
  • Update links

Release Note

NONE

Documentation

Images not migrated, tracked in #26
Other comments from doc to be filed as issues (if still relevant)

Signed-off-by: Tracy Miranda <[email protected]>
@tracymiranda tracymiranda mentioned this pull request Sep 26, 2024
Copy link

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Since I wrote this, let's have some other eyes

Can we add a link to the v2 doc as well?

Can you record follow ups as issues, I know there were a bunch of comments on the spec doc?

Signed-off-by: Luke Hinds <[email protected]>
@lukehinds
Copy link
Member

a couple of typos fixed in c776ad6, but looks good to me.

Copy link
Member

@kommendorkapten kommendorkapten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tracymiranda
Copy link
Author

Thank you all!
I've opened #30 to track all the comments and address them, and also #31 for the rekor v2 spec (will be good to have that added as a distinct commit).

This PR is ready for merging

@haydentherapper haydentherapper merged commit 7f63462 into sigstore:main Nov 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants