Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key manager API: implement standard Graffiti management APIs #4947

Closed
jimmygchen opened this issue Nov 23, 2023 · 3 comments
Closed

Key manager API: implement standard Graffiti management APIs #4947

jimmygchen opened this issue Nov 23, 2023 · 3 comments
Assignees
Labels
HTTP-API val-client Relates to the validator client binary

Comments

@jimmygchen
Copy link
Member

Description

New GET, POST, DELETE graffiti endpoints are being added to Key Manager API spec and needs to be implemented:
ethereum/keymanager-APIs#63

Lighthouse already implement some custom APIs to manage graffitis:

  • GET /lighthouse/ui/graffiti
  • PATCH /lighthouse/validators/:voting_pubkey

These existing endpoints should remain unchanged as they are used by the Siren UI and are slightly different to the standard APIs. For the new POST endpoint, we should implement a similar logic when updating the validator graffiti to the existing PATCH endpoint:

This endpoint updates the graffiti in both the validator definition file and the in memory InitializedValidators. In the next block proposal, the new graffiti will be used.

Note that the --graffiti-file flag has a priority over the validator definitions file, so if the caller attempts to update the graffiti while the --graffiti-file flag is present, the endpoint will return an error (Bad request 400).

^ and perhaps return 403 instead of 400 to be more spec compliant.

@jimmygchen jimmygchen added val-client Relates to the validator client binary HTTP-API labels Nov 23, 2023
@eserilev
Copy link
Collaborator

I'd like to pick this up

@jimmygchen
Copy link
Member Author

That's great, thanks @eserilev !

@jimmygchen
Copy link
Member Author

Completed in #4951 , thanks @eserilev !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HTTP-API val-client Relates to the validator client binary
Projects
None yet
Development

No branches or pull requests

2 participants