From 761a2c74f932c4223efb98ba7f2a842679b61bee Mon Sep 17 00:00:00 2001 From: Alessandro Aimi Date: Tue, 8 Oct 2024 12:27:06 +0200 Subject: [PATCH] Remove "applications" module from dependencies --- .github/actions/build/action.yml | 2 +- .github/workflows/linting.yml | 2 +- README.md | 6 ++---- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/actions/build/action.yml b/.github/actions/build/action.yml index 54e910866f..41ada87586 100644 --- a/.github/actions/build/action.yml +++ b/.github/actions/build/action.yml @@ -27,7 +27,7 @@ runs: run: > CXX=$COMPILER ./ns3 configure -d $MODE -GNinja --enable-examples --enable-tests --enable-asserts --enable-werror - --enable-modules "lorawan;applications" $EXTRA_OPTIONS + --enable-modules lorawan $EXTRA_OPTIONS # Build steps - name: "Build ns-3" shell: bash diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index 5d1e0b749e..0111d083fa 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -35,7 +35,7 @@ jobs: run: > ./ns3 configure -d debug --enable-examples --enable-tests --enable-asserts - --enable-modules "lorawan;applications" + --enable-modules lorawan --enable-clang-tidy # Use a trick (git diff on empty tag) to only run clang-tidy on the lorawan module - name: "Running clang-tidy" diff --git a/README.md b/README.md index 27854b04aa..8917ff0631 100644 --- a/README.md +++ b/README.md @@ -70,11 +70,9 @@ Finally, ensure tests run smoothly with: ./test.py ``` -If the script reports that all tests passed or that just `three-gpp-propagation-loss-model` failed[^1], you are good to go. +If the script reports that all tests passed you are good to go. -If other tests fail or crash, consider filing an issue. - -[^1]: This is due to [a bug in the current ns-3 version](https://gitlab.com/nsnam/ns-3-dev/-/issues/965) when restricting compilation to the lorawan module and its dependencies. If you need to use the `three-gpp-propagation-loss-model`, you can solve this by compiling ns-3 as a whole or with the `--enable-modules "lorawan;applications"` option to reduce compilation time. +If some tests fail or crash, consider filing an issue. ## Usage examples