fix: shouldn't htmlEntities and htmlNumbers pass ? #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just by chance I looked at this pr when was opened
and I asked myself whether or not the
escapeHtml
should ignore htmlEntities and htmlNumbersthis would mean no transformation for those occurrences when using
markdown: true
, which makes a lot of sense to my eyesin case it actually should behave like that, this pr fixes it accordingly, changing the bare minimum.
actually that function could also be reduced to
please let me know your thoughts on that