Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env var description and fix URL #19

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

munteanuic
Copy link
Collaborator

@munteanuic munteanuic commented Sep 5, 2024

This PR is making the following changes:

  • EXTERNAL_USER_TEAM in env variables will be unpopulated and will have a description placeholder instead
  • The URL has a trailing '?' when all of the URL params become undefined. We'll only add the '?' if there are URL params
  • The sharingLink passed to the iframe event shouldn't have any exploreId. We save links with exploreIds for the variable sharingExplorationLink
  • Variable 'Final Sharing Link' is confusing since there is no Initial Sharing Link. In my opinion 'Sharing Link' is sufficient.

@munteanuic munteanuic requested a review from pballai September 5, 2024 20:44
@pballai pballai merged commit aff410e into main Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants