-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type name collision / re-enable renaming #16
Comments
Hmmm...this does seem tricky. It's not nice to require users to rename there types all over the place. Ideally, types wouldn't be global, but could be in typescript modules, but I don't think there's a way to deduce that from inside a Rust macro. If you have name collisions, you should be able to use the |
Apparently |
Previously
#[serde(rename = "...")]
can be used to rename types, but it had a problem when the type is referenced in other types madonoharu#43However, without renaming, there could be name collisions
becomes
To fix this, 3e81856 could be reverted to enable rename again, and madonoharu#43 can be addressed with
#[tsify(type = "RenamedType")]
The text was updated successfully, but these errors were encountered: