Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Banner for production #583

Merged
merged 12 commits into from
Mar 7, 2023
Merged

feat: Banner for production #583

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a4c290c
feat: Banner for production
KirillDogadin-std Feb 7, 2023
1f0fe65
wording
KirillDogadin-std Feb 7, 2023
98272f1
adjust readme
KirillDogadin-std Feb 7, 2023
3079caa
adjust story
KirillDogadin-std Feb 7, 2023
ee72532
Merge branch 'main' into banner-electron
aomafarag Mar 7, 2023
14d4ecc
Revert some changes in preparation for refactoring
aomafarag Mar 7, 2023
0a594d4
Add new case for production
aomafarag Mar 7, 2023
4fda81b
Remove unnecessary component
aomafarag Mar 7, 2023
865292f
Revert commits after ee72532
aomafarag Mar 7, 2023
c61ec4b
Use Alert banner
aomafarag Mar 7, 2023
d491b1c
Add env var to Dockerfile and .drone
aomafarag Mar 7, 2023
93a103c
add PRODUCTION_BANNER_URL to the publish-frontend-makerdao-on-tag step
valiafetisov Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ data:
value_from_secret: auction-ui/main.auction-ui.k8s.sidestream.tech/frontend/contact_email
- key: STAGING_BANNER_URL
value_from_secret: auction-ui/main.auction-ui.k8s.sidestream.tech/frontend/staging_banner_url
- key: PRODUCTION_BANNER_URL
value_from_secret: auction-ui/main.auction-ui.k8s.sidestream.tech/frontend/production_banner_url
Comment on lines +25 to +26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only add it to the main.auction-ui.k8s.sidestream.tech (which is staging). You also need to add it down to publish-frontend-makerdao-on-tag step

- key: HEAPIO_ID
value_from_secret: auction-ui/main.auction-ui.k8s.sidestream.tech/frontend/heapio_id
- key: FRONTEND_ORIGIN
Expand Down Expand Up @@ -214,8 +216,8 @@ data:
aws_target_eks_cluster_name: eks-cluster-sidestream
aws_ssm_path_to_base64_encoded_secrets_yaml: auction-ui/secrets.yaml
value_files:
- values.yaml
- values.override_main.auction-ui.k8s.sidestream.tech.yaml
- values.yaml
- values.override_main.auction-ui.k8s.sidestream.tech.yaml
target_namespace: "auction-ui-main"
release_name: "auction-ui"
values_to_set:
Expand All @@ -234,8 +236,8 @@ data:
aws_target_eks_cluster_name: eks-cluster-sidestream
aws_ssm_path_to_base64_encoded_secrets_yaml: auction-ui/secrets.yaml
value_files:
- values.yaml
- values.override_unified-auctions.makerdao.com.yaml
- values.yaml
- values.override_unified-auctions.makerdao.com.yaml
target_namespace: "auction-ui-production"
release_name: "auction-ui"
values_to_set:
Expand Down Expand Up @@ -299,7 +301,7 @@ data:
- npm run test

services:
- name: hardhat-service # named with 'service' to avoid duplication with the default value
- name: hardhat-service # named with 'service' to avoid duplication with the default value
image: ghcr.io/sidestream-tech/unified-auctions-ui/core-hardhat:pr-${DRONE_PULL_REQUEST}
expose: 8545

Expand Down
2 changes: 2 additions & 0 deletions frontend/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ ARG CONTACT_EMAIL
ENV CONTACT_EMAIL=${CONTACT_EMAIL}
ARG STAGING_BANNER_URL
ENV STAGING_BANNER_URL=${STAGING_BANNER_URL}
ARG PRODUCTION_BANNER_URL
ENV PRODUCTION_BANNER_URL=${PRODUCTION_BANNER_URL}
ARG HEAPIO_ID
ENV HEAPIO_ID=${HEAPIO_ID}
ARG FRONTEND_ORIGIN
Expand Down