Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS - Message.unpack fails with silent SIGBUS error #97

Open
vongohren opened this issue Nov 23, 2022 · 0 comments
Open

TS - Message.unpack fails with silent SIGBUS error #97

vongohren opened this issue Nov 23, 2022 · 0 comments

Comments

@vongohren
Copy link

What

Have friendly errors when a method can receive all types, DO NOT crash with a SIGBUS error.
Sending inn a JSON obj into unpack, which is allowed by the types, crashes silently with a SIGBUS error. Trying to debug this was not that easy: nodejs/help#3168

But the library should throw a friendly error if JSON objects are not possible to send in for unpack.
Only string works at the moment

Why

This needs to be fixed for a better DX, as SIGBUS is not caught by try catch, and it can fail silently depending on how one run its code. This is a very bad DX.

Success Criteria

Fail if one send in something the unpack method dont expect. Fail with a proper error so the developer can understand.
Or if JSON objects are OK, which they should be, dont crash unexpectadly.

@vongohren vongohren changed the title Message.unpack fails with silent SIGBUS error TS - Message.unpack fails with silent SIGBUS error Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant