Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart improvements #203

Open
rjahn opened this issue Sep 29, 2023 · 10 comments
Open

Chart improvements #203

rjahn opened this issue Sep 29, 2023 · 10 comments
Labels
bug Something isn't working waiting on library If issue can't progress because library has a bug/needs to update something
Milestone

Comments

@rjahn
Copy link
Member

rjahn commented Sep 29, 2023

Pie chart:

If you have long labels, the labels are inside the chart and overlap other areas in the chart. With short labels it looks better but only as long as the segment is big enough.

Same in chart legend. Label too long, overlaps other labels.

We could try if there's a feature in the chart library to move labels outside the chart and shorten the legend or set clipping areas?

If we can't fix it with existing API: open an issue for the chart library

@rjahn rjahn added the help wanted Extra attention is needed label Sep 29, 2023
@rjahn rjahn added this to the 3.0.0 milestone Sep 29, 2023
@ToniHeiss
Copy link
Contributor

Example for the pie chart.

grafik

@ToniHeiss ToniHeiss added bug Something isn't working Priority and removed help wanted Extra attention is needed labels Nov 13, 2023
@ToniHeiss
Copy link
Contributor

Affects new charts implemented by #169

@ToniHeiss
Copy link
Contributor

There does not seem to be a solution for the labels in pie charts with this library.

@ToniHeiss
Copy link
Contributor

Current open issues:
entronad/graphic#275
entronad/graphic#259

@rjahn
Copy link
Member Author

rjahn commented Nov 28, 2023

labels outside the chart are working with rose chart, but I guess this chart type is a special solution?

@ToniHeiss
Copy link
Contributor

ToniHeiss commented Nov 28, 2023

grafik
would look like this then, would not be a pie chart anymore.

@rjahn
Copy link
Member Author

rjahn commented Nov 28, 2023

It was just an input that this chart type shows labels outside

@ToniHeiss
Copy link
Contributor

ToniHeiss commented Nov 28, 2023

Yeah, the chart seems to do that automatically. PieCharts have the label inside them and RoseCharts have them outside. There is a way to offset them into one direction, but this either affects ALL labels, so i can shift all labels down, right, up, left, or i calculate an individual offset for each label. That would be a possibility, but I have not yet found an exact way. I would first have to calculate the current position of the label myself with just the value and then calculate a necessary offset. Even if that is solved, a new problem arises then that we can't know if the label is then so much "offset" that it is actually now outside the whole layout area of the chart itself.

It just does not seem that feasable at the moment.

@ToniHeiss ToniHeiss added the waiting on library If issue can't progress because library has a bug/needs to update something label Nov 29, 2023
@ToniHeiss
Copy link
Contributor

PieChart selection ticket:
entronad/graphic#276

Currently only possible to select the line in the middle between elements.

ToniHeiss added a commit that referenced this issue Dec 1, 2023
@rjahn rjahn modified the milestones: 3.0.0, 3.0.2 Dec 11, 2023
@rjahn rjahn modified the milestones: 3.0.2, 3.1.0 Dec 29, 2023
@rjahn rjahn modified the milestones: 3.2.0, 3.8.0 Oct 1, 2024
@entronad
Copy link

The pie label issue solution is here:

entronad/graphic#275 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting on library If issue can't progress because library has a bug/needs to update something
Projects
None yet
Development

No branches or pull requests

4 participants